chore(gitignore): anchor binary names to repo root#2522
Merged
Conversation
The bare `github-mcp-server`, `mcpcurl`, and `e2e.test` rules matched those names anywhere in the tree, which silently ignored new files created under `cmd/github-mcp-server/` (the rule treats the directory component as a match). The intent was to ignore the binaries produced by `go build` at repo root, so anchor each rule with a leading slash. The existing `cmd/github-mcp-server/github-mcp-server` rule on line 2 continues to ignore the binary when built inside the cmd directory. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bare
github-mcp-server,mcpcurl, ande2e.testentries in.gitignorematched those names anywhere in the tree, which silently ignored any new file added undercmd/github-mcp-server/(the rule matched the directory component). I hit this while adding a new.gofile to that directory in #2521 — it was invisible togit statusuntilgit add -f.The intent of those rules was to ignore the binaries produced by
go buildat repo root, so this anchors each one with a leading slash. The existingcmd/github-mcp-server/github-mcp-serverrule on line 2 still covers the binary when built inside the cmd directory.Verification
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com